git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] name-rev: Fix non-shortest description

From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date
Aug 27, 2007, 19:27 UTC
Message-ID
<20070827192735.GB20753@informatik.uni-freiburg.de>
In-Reply-To
<Pine.LNX.4.64.0708231557590.20400@racer.site>
Johannes Schindelin wrote:
Show 11 quoted lines
> 
> Uwe Kleine-König noticed that under certain circumstances, name-rev
> picked a non-optimal tag.  Jeff King analyzed that name-rev only
> takes into account the number of merge traversals, and then the
> _last_ number in the description.
> 
> As an easy way to fix it, use a weighting factor for merge traversals:
> A merge traversal is now made 65535 times more expensive than a
> first-parent traversal.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Just from looking at the patch it seems to do what the log says. It passes the test suite and fixed my use case. So:

Acked-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>

But if I'd really prefer to know the "oldest" tag that includes the given rev, I don't want that weighting. I will try to come up with a patch that introduces a flag.

Best regards and thanks to Johannes Uwe

-- 
Uwe Kleine-König

primes where sieve (p:xs) = [ x | x<-xs, x `rem` p /= 0 ]; \
primes = map head (iterate sieve [2..])
Previous: Johannes Schindelin
Message 13 of 13 in “name-rev does not show the shortest path”
  1. Uwe Kleine-KönigAug 23, 2007
  2. Julian PhillipsAug 24, 2007
  3. Uwe Kleine-KönigAug 24, 2007
  4. Julian PhillipsAug 24, 2007
  5. Junio C HamanoAug 24, 2007
  6. Johannes SchindelinAug 25, 2007
  7. Jeff KingAug 26, 2007
  8. Johannes SchindelinAug 26, 2007
  9. Jeff KingAug 27, 2007
  10. Johannes SchindelinAug 27, 2007
  11. Johannes SchindelinAug 27, 2007
  12. name-rev: Fix non-shortest descriptionJohannes Schindelin, Aug 27, 2007
  13. Uwe Kleine-KönigAug 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.