Re: 'pu' branch for StGIT

From: Karl Hasselström <kha@treskal.com>
Date: Aug 8, 2007, 21:39 UTC
Message-ID: <20070808213917.GA22521@diana.vm.bytemark.co.uk>
In-Reply-To: <20070808092027.GB7860@diana.vm.bytemark.co.uk>

On 2007-08-08 11:20:27 +0200, Karl Hasselström wrote:

Show 6 quoted lines

> On 2007-08-08 01:03:53 -0400, Pavel Roskin wrote:
>
> > Also, "stg import" commits the patch, which seems wrong to me.
>
> Hmm, I hadn't noticed. That would be an unintended side-effect of
> the DAG patches, presumably. I'll look into it tonight.

I can't reproduce. (Using master of git://repo.or.cz/stgit/kha.git.) The last subtest of t1800 actually tests that a mailbox was imported as a series of patches, and that works fine for me (the other subtests don't make sure that a patch was created; they just verify that we got the right tree). Furthermore, the following works for me:

kha@yoghurt:~/stgit/t> ./t1800-import.sh
*   ok 1: Initialize the StGIT repository
*   ok 2: Apply a patch created with "git diff"
*   ok 3: Apply a patch created with GNU diff
*   ok 4: Apply a patch created with "stg export"
*   ok 5: Apply a patch from an 8bit-encoded e-mail
*   ok 6: Apply a patch from a QP-encoded e-mail
*   ok 7: Apply several patches from an mbox file
* passed all 7 test(s)
kha@yoghurt:~/stgit/t> cd trash/
kha@yoghurt:~/stgit/t/trash> ls
foo.txt
kha@yoghurt:~/stgit/t/trash> PATH=/home/kha/stgit:$PATH stg series -d
kha@yoghurt:~/stgit/t/trash> PATH=/home/kha/stgit:$PATH stg import -m ../t1800-import/email-qp
Checking for changes in the working directory ... done
Finding uninteresting commits ... done
Importing patch "email-qp" ... done
Now at patch "email-qp"
kha@yoghurt:~/stgit/t/trash> PATH=/home/kha/stgit:$PATH stg series -d

> email-qp | test patch

So a patch is definitely created. Could you describe in more detail exactly what you do to make it fail?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle