Re: [PATCH] git-gui: Added support for OS X right click

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 4, 2007, 07:33 UTC
Message-ID: <20070804073321.GU20052@spearce.org>
In-Reply-To: <20070804071131.GA6557@coredump.intra.peff.net>

Jeff King <peff@peff.net> wrote:

Show 5 quoted lines

> On Sat, Aug 04, 2007 at 02:55:16AM -0400, Shawn O. Pearce wrote:
> 
> > V??in?? J??rvel?? <v@pp.inet.fi> wrote:
> 
> Your mailer claims this message is in us-ascii, but I think it isn't...

My mutt-foo isn't very good. I tried to tell it utf-8, but I think its ignoring me:

  set allow_8bit=yes
  set charset=utf8

:-/

Show 6 quoted lines

> I tried reproducing the encoding breakage and it ended up fine. I just
> edited the patch in the .dotest directory (looks like the leading spaces
> were all stripped) and it applied fine when I re-ran "git-am".
> 
> Are you sure it didn't get munged by your editor when you hand-edited
> the mbox file?

I just tried to reproduce it myself and I can't do whatever I did before again now; it Just Works(tm). *sigh* No idea how I messed the patch application up earlier, but I did.

It wasn't my patch editing. My vi clone only works on bytes, so it doesn't care about character encodings and won't mangle them unless I edit a utf-8 multibyte sequence by hand. Which I'm sure I didn't do. And the first time I messed up the apply I was fixing up only .dotest/patch, which was most certainly just us-ascii.

I'm actually pretty good about making sure I don't munge people's non-ASCII names, but my mutt seems to think us-ascii is the only character encoding in the world.

-- 
Shawn.