Re: [PATCH] git-gui: Added support for OS X right click
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Aug 4, 2007, 06:55 UTC
- Message-ID
- <20070804065516.GS20052@spearce.org>
- In-Reply-To
- <C4431971-A1F1-463E-B238-D351FCBB57F8@pp.inet.fi>
V??in?? J??rvel?? <v@pp.inet.fi> wrote:
> OS X sends Button-2 on a "real" right click, such as with a three > button mouse, or by using the two-finger trackpad click.
Thanks, this will be in 0.8.1. I'm pushing it out shortly.
I had a devil of a time applying your patch though. git-am choked because the patch was whitespace damaged, and then after hand-correction and resuming it horribly munged your name's encoding in the commit. I think there's a bug in there in git-am; I'll have to try to track it down. I managed to get the patch applied correctly by editing the mbox file directly, so that git-am did not need to stop and ask me to resolve the patch.
It seems that Apple's Mail.app just doesn't like to send patches without destroying them. If you do wind up sending another patch in the future it may just be easier if you attach the mbox that format-patch creates, instead of trying to inline it in the message body.
-- Shawn.