Re: [GUILT PATCH 0/4] Add guards to guilt

From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Date: Jul 30, 2007, 03:54 UTC
Message-ID: <20070730035443.GC22017@filer.fsl.cs.sunysb.edu>
In-Reply-To: <118569541814-git-send-email-eclesh@ucla.edu>

On Sun, Jul 29, 2007 at 12:50:14AM -0700, Eric Lesh wrote:

> 
> This series adds Mercurial Queues-like guards to guilt.  It allows you
> to assign guards to related patches in the series file to selectively
> push patches.

Neat. I actually never looked into guards, but you forced me to :) Very interesting concept. I think it would be worth it having such functionality in guilt.

I know I've been bad about forcing even myself to write new regression tests. Your patches modify things significantly enough, that I'd like to see some regression tests cases to make sure that user's data is not eaten (e.g., a bug in the guard setting code could blow away the series file => very bad).

> This introduces the command `get_guarded_series`, which just lists
> patches that are to be applied based on the guards.  It also makes
>         eidx=`wc -l < $applied`
> inaccurate if you're using it as an index into get_series.

The index-based patch finding is a bit nasty anyway.

> If you change guards on a patch or select a different guard while
> patches are applied, some commands might get confused. guilt pop -a will fix
> everything though.  Usually, it's best to pop -a before fiddling with
> guards anyway.

Is this a problem with other projects' implementations of guards as well? Perhaps printing a warning if a new guard is set when there are applied patches would be in order?

> This is an RFC, but I have tested it and things seem to be working
> well.

Great!

I'm going to reply to each of the patches separately with any comments.

Josef 'Jeff' Sipek.

-- 
Penguin : Linux version 2.4.20-46.9.legacysmp on an i386 machine (2778.72 BogoMips).