Re: [GUILT PATCH 1/4] get_series: Remove comments from end of series lines

From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Date: Jul 30, 2007, 03:54 UTC
Message-ID: <20070730035422.GB22017@filer.fsl.cs.sunysb.edu>
In-Reply-To: <11856954183111-git-send-email-eclesh@ucla.edu>

On Sun, Jul 29, 2007 at 12:50:15AM -0700, Eric Lesh wrote: ...

Show 11 quoted lines

> diff --git a/guilt b/guilt
> index f67bfb5..774909e 100755
> --- a/guilt
> +++ b/guilt
> @@ -178,7 +178,8 @@ get_series()
>  	#	- whitespace only
>  	#	- optional whitespace followed by '#' followed by more
>  	#	  optional whitespace
> -	grep -ve '^[[:space:]]*\(#.*\)*$' "$series"
> +	# also remove comments from end of lines
> +	grep -ve '^[[:space:]]*\(#.*\)*$' < "$series" | sed -e 's/[[:space:]]*#.*$//'

I'd be tempted to replace the whole thing with one sed script...something like (not tested):

"
/^[[:space:]]*#/ ! {
	s/[[:space:]]*#.*$//

	p
}
"

Regardless of the other 3 patches, this one makes sense to include.

Josef 'Jeff' Sipek.

-- 
Once you have their hardware. Never give it back.
(The First Rule of Hardware Acquisition)