Re: [PATCH] git-gui wording suggestions

From: Christian Stimming <stimming@tuhh.de>
Date: Jul 27, 2007, 11:42 UTC
Message-ID: <20070727134219.wjkkfyg0g888ooss@webmail.tu-harburg.de>
In-Reply-To: <20070727044009.GF20052@spearce.org>

Quoting "Shawn O. Pearce" <spearce@spearce.org>:

Show 10 quoted lines

>> Unifiy wording to say "to stage" instead of "to add" always.
> ...
>> With this patch I'd propose to talk every only about "stage" instead
>> of "add". IMHO that's just the logical conclusion of the above wording
>> decision. What do you think?
>
> Yes, I agree.  This is a necessary change, the current wording is
> very confusing.  I would apply this earlier than the other i18n
> stuff, but this patch is written based upon the current i18n work.
> :-|

Well, of course I have supplied this patch on top of the current i18n markup work... on the other hand, back-porting the string changes to the non-i18n code means that the i18n changes themselves won't merge anymore. For that reason I wouldn't suggest to apply this separately from the i18n commits, unless you would want to adapt the i18n patches as well.

I'd rather suggest to consider the i18n changes rather soon by now, even if the actual translations will be merged later. The [mc...] calls itself don't change the behaviour of the application, so I don't think it would be very risky do merge them sooner than later. Eventually, that's of course up to you.

Christian