Re: [PATCH] Fix git-p4 on Windows to not use the Posix sysconf
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jul 15, 2007, 02:49 UTC
- Message-ID
- <20070715024928.GY4436@spearce.org>
- In-Reply-To
- <200707131533.55544.simon@lst.de>
Simon Hausmann <simon@lst.de> wrote:
Show 9 quoted lines
> On Friday 13 July 2007 15:03:51 Alex Riesen wrote:
> > On 7/13/07, Marius Storm-Olsen <marius@trolltech.com> wrote:
> > > argmax = min(4000, os.sysconf('SC_ARG_MAX'))
> >
> > I wonder why the code in question does not use "-x"?
> > I use it git-p4-import and haven't seen the limit yet.
>
> I still think the patch makes sense as stop-gap for 1.5.3 though, because
> without it git-p4 doesn't work at all on Windows.Thanks. Marius' patch was whitespace damaged in the context lines, but it was easily repaired. I've got a couple of other small items in my fastimport repository that I'm going to ask Junio to include in 1.5.3 shortly.
-- Shawn.