Re: [PATCH] Fix git-p4 on Windows to not use the Posix sysconf

From: Simon Hausmann <simon@lst.de>
Date: Jul 13, 2007, 13:33 UTC
Message-ID: <200707131533.55544.simon@lst.de>
In-Reply-To: <81b0412b0707130603q69857564i1ba418b74397a33d@mail.gmail.com>

On Friday 13 July 2007 15:03:51 Alex Riesen wrote:

Show 13 quoted lines

> On 7/13/07, Marius Storm-Olsen <marius@trolltech.com> wrote:
> >      argmax = min(4000, os.sysconf('SC_ARG_MAX'))
>
> I wonder why the code in question does not use "-x"?
> I use it git-p4-import and haven't seen the limit yet.
> I.e.:
>
>    $ ls |p4 -x - print -q
>    $ p4 help usage
>    ...
>    The -x flag instructs p4 to read arguments, one per line, from the
>    named file.  If the file is named '-', then standard input is read.
>    ...

Good idea!

I still think the patch makes sense as stop-gap for 1.5.3 though, because without it git-p4 doesn't work at all on Windows.

Simon