Re: git-rm isn't the inverse action of git-add
- From
- Jan Hudec <bulb@ucw.cz>
- Date
- Jul 11, 2007, 18:56 UTC
- Message-ID
- <20070711185644.GA3069@efreet.light.src>
- In-Reply-To
- <f72hu8$65g$1@sea.gmane.org>
On Wed, Jul 11, 2007 at 14:20:24 +0200, Jakub Narebski wrote:
Show 11 quoted lines
> Christian Jaeger wrote: > > I don't per se require undo actions. I just don't understand why git-rm > > refuses to remove the file from the index, even if I didn't commit it. > > The index is just an intermediate record of the changes in my > > understandings, and the rm action would also be intermediate until it's > > being committed. And a non-committed action being deleted shouldn't need > > a special confirmation from me, especially not one which is consisting > > of a combination of two flags (of which one is a destructive one). > > Should git-rm refuse to remove index entry if it is different from working > directory version or not?
IMHO it should refuse to remove index entry if it is different from both working-tree version and versions in all parents.
If index matches any of that, but the working tree version does not match any parent, the index entry should be removed (which currently isn't -- that's the proposed change), but the file left in wokring tree. That would make git-add + git-rm get you right back where you started, with nothing in index and unversioned file in working tree.
-- Jan 'Bulb' Hudec <bulb@ucw.cz>