Re: [Qgit RFC] commit --amend

From: Jan Hudec <bulb@ucw.cz>
Date: Jul 1, 2007, 12:26 UTC
Message-ID: <20070701122625.GC26243@efreet.light.src>
In-Reply-To: <e5bfff550706102245p27aea579w65ee96161630a624@mail.gmail.com>

On Mon, Jun 11, 2007 at 07:45:51 +0200, Marco Costalba wrote:

Show 29 quoted lines

> On 6/11/07, Jan Hudec <bulb@ucw.cz> wrote:
> >
> >I think I mostly understood it now. Thank you.
> >
> 
> Anyhow I think this could be useful to you:
> 
> 	/*
> 	   getAllRefSha() returns the list of sha of a given
> 	   type, where type is a mask of Git::RefType flags
> 	   see src/git.h.
> 	   In this case we want the sha of the current branch
> 	*/
> 	QStringList revs = getAllRefSha(CUR_BRANCH);
> 	
> 	if (!revs.isEmpty()) {
> 
> 		// all the sha info is stored in this QGit::Rev
> 		// class defined in src/common.h
> 		const Rev* r = revLookup(revs.first());
> 
> 		// short log (title) is
> 		r->shortLog();
> 
> 		// message body is
> 		r->longLog();
> 
> 		// etc....
> 	}

Thanks.

I got stuck at git-commit --amend -F not working (because it's explicitely forbidden), so I have to reimplement all of the commit stuff with plumbing commands. I am in the middle of rewriting it currently. Unfortunately the plumbing is a little too low-level.

However, I am currently not sure how to handle errors. If the current commit fails, it will show a message box with it's output, but I can't see where it is generated. It seems it's somewhere inside MyProcess, so I don't have to do anything special though, right?

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>