git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Qgit RFC] commit --amend

From
JHJan Hudec <bulb@ucw.cz>
Date
Jun 10, 2007, 15:08 UTC
Message-ID
<20070610150839.GG4084@efreet.light.src>
Hello,
I am thinking about adding commit --amend support to Qgit.

However I see three ways to do it, so I'd like to ask whether anybody knows some reason why any of them is better or worse, which I don't:

 - Add a button for "Amend". This would fit with what is there currently,
   because with stgit it has buttons "New patch" and "Add to top" (refresh),
   which correspond exactly to core git's "commit" and "commit --amend"
   respectively.
   Disadvantage (for current approach too) is, that when amending (resp.
   refreshing) the previous commit message is not there to be edited.
 - Add a radio button the way git-gui does. Switching the button to "amend"
   would load the previous commit message.
   This would be more invasive change, but it would allow editing the commit
   message when amending/refreshing. I fear it will be more user-error-prone
   too, though.
 - Add a separate action to the menu. This action would take over the refresh
   (Add to top) operation when using stgit.
   
   I believe this has lower risk of user errors than the previous option. It
   also has the advantage, that I don't have to touch the disabling logic for
   the commit action. Amending last commit is always possible, even if there
   are no changes, because you might want to edit the message (eg. if you
   forget to sign-off or forget to mention some change or something).

I'll try doing the first option now, unless somebody persuades me that it's a nonsense.

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>
Next: Marco Costalba
Message 1 of 17 in “[Qgit RFC] commit --amend”
  1. Jan HudecJun 10, 2007
  2. Marco CostalbaJun 10, 2007
  3. Jan HudecJun 11, 2007
  4. Marco CostalbaJun 11, 2007
  5. Marco CostalbaJun 11, 2007
  6. Jan HudecJul 1, 2007
  7. Marco CostalbaJul 1, 2007
  8. Jan HudecJul 2, 2007
  9. Junio C HamanoJul 4, 2007
  10. Marco CostalbaJul 4, 2007
  11. Jan HudecJul 4, 2007
  12. Junio C HamanoJul 4, 2007
  13. Marco CostalbaJul 6, 2007
  14. Jan HudecJul 5, 2007
  15. Marco CostalbaJul 6, 2007
  16. Jan HudecJul 8, 2007
  17. Marco CostalbaJul 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.