Re: [PATCH guilt] make guilt use standard POSIX shell

From: Pierre Habouzit <madcoder@debian.org>
Date: Jun 14, 2007, 17:16 UTC
Message-ID: <20070614171611.GW23324@artemis>
In-Reply-To: <20070614163940.GA4752@filer.fsl.cs.sunysb.edu>

On Thu, Jun 14, 2007 at 12:39:40PM -0400, Josef Sipek wrote:

Show 14 quoted lines

> On Thu, Jun 14, 2007 at 05:58:26PM +0200, Pierre Habouzit wrote:
> > On Thu, Jun 14, 2007 at 05:56:00PM +0200, Pierre Habouzit wrote:
> > > On Thu, Jun 14, 2007 at 11:27:02AM -0400, Josef Sipek wrote:
> > > > Thanks a lot!
> > > 
> > >   Well, worry for the obvious mistakes.
> >          *sorry
> > 
> >   Now, *that* was an interesting typo :P
> 
> :)
> 
> Ok, pushed to kernel.org. I folded the 2 regression fixing patches into the
> right places.

  Just a small remark: 87739d0e should be merged in the master branch,
as the regression suite does not work atm if you are using a shell that
does not understands enough bashisms.

  The patch is safe (it only adds /bin/bash shebangs to tests, and
changes the way tests are called in the Makefile).

  For the rest, I agree the patches should continue to live in a
separate branch until better coverage of the testsuite can give us more
faith in those patches :)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org