Re: [PATCH] guilt(1): Obvious bashisms fixed.
On Thu, Jun 14, 2007 at 11:15:12AM -0400, Josef Sipek wrote:
Show 35 quoted lines
> On Thu, Jun 14, 2007 at 02:50:57PM +0200, Pierre Habouzit wrote:
> > + function foo { } -> foo() { }
> > + add wrapper for echo -e
> > + couple of '[' bashisms
> > + get rid of easy local variables to remove
> > + avoid cd - (using subshells)
> ....
>
> Just a small nit-pick :)
>
> > diff --git a/guilt b/guilt
> > index 2ae76f8..80f3faf 100755
> > --- a/guilt
> > +++ b/guilt
> > @@ -20,7 +20,29 @@ SUBDIRECTORY_OK=1
> ....
> > +guilt_commands()
> > {
> > local command
> > for command in $0-*
> > @@ -32,7 +54,7 @@ function guilt_commands
> > done
> > }
> >
> > -if [ `basename $0` = "guilt" ]; then
> > +if [ "`basename $0`" = "guilt" ]; then
>
> You added quotes here - that's ok....
>
> > # being run as standalone
> >
> > # by default, we shouldn't fail
> > @@ -58,7 +80,7 @@ if [ `basename $0` = "guilt" ]; then
>
> But did not add them here.... :) heh, I tried my best, I've no automated tool for that, only my eyes
and thise code will break iff `basename $0` has spaces in it, which is
rather crazy anyways. But you're welcome to add the missing ones *sigh*
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>