git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Teach Makefile to respect external variables: CFLAGS and others.

From
MLMatthias Lederhofer <matled@gmx.net>
Date
Jun 13, 2007, 07:42 UTC
Message-ID
<20070613074240.GA12894@moooo.ath.cx>
In-Reply-To
<20070613071514.GP86872@void.codelabs.ru>
Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
Show 22 quoted lines
> Junio, Sam, good day.
> 
> Tue, Jun 12, 2007 at 11:07:56PM -0700, Junio C Hamano wrote:
> > I run "make CFLAGS=-O0 -g" all the time.  Also "make CC=echo"
> > seems to "work" as expected ;-).
> > 
> > Care to elaborate what problem you are trying to solve?
> 
> As Sam Ravnborg kindly pointed out, you're using make variables
> and I am trying to give the respect to the environment variables.
> 
> And the real problem is that one (for example, me) can try to
> build Git with the different compiler than CC (gccX or icc, for
> example).  And it is much better for lazy people to do 'export
> CC=whatever' once and then fire make any number of times ;))
> 
> Answering Sam: yes, with my patch it is easier to inherit the
> variables from the environment.  But it is not clear if it is
> good or bad ;))
> 
> But anyway, this patch is only my suggestion, and it can be
> thrown away :)

If you want to fix it for your own checkout of git just put whatever you like in config.mak. For example I add -ggdb3 to CFLAGS, set the prefix variable and add some custom make targets in this file.

Previous: Eygene RyabinkinNext: Sam Ravnborg
Message 6 of 7 in “Teach Makefile to respect external variables: CFLAGS and others.”
  1. Teach Makefile to respect external variables: CFLAGS and others.Eygene Ryabinkin, Jun 13, 2007
  2. Junio C HamanoJun 13, 2007
  3. Eygene RyabinkinJun 13, 2007
  4. Junio C HamanoJun 13, 2007
  5. Eygene RyabinkinJun 13, 2007
  6. Matthias LederhoferJun 13, 2007
  7. Sam RavnborgJun 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.