Re: [PATCH] Teach Makefile to respect external variables: CFLAGS and others.

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: Jun 13, 2007, 07:15 UTC
Message-ID: <20070613071514.GP86872@void.codelabs.ru>
In-Reply-To: <7v4plcgzer.fsf@assigned-by-dhcp.pobox.com>

Junio, Sam, good day.

Tue, Jun 12, 2007 at 11:07:56PM -0700, Junio C Hamano wrote:

> I run "make CFLAGS=-O0 -g" all the time.  Also "make CC=echo"
> seems to "work" as expected ;-).
> 
> Care to elaborate what problem you are trying to solve?

As Sam Ravnborg kindly pointed out, you're using make variables and I am trying to give the respect to the environment variables.

And the real problem is that one (for example, me) can try to build Git with the different compiler than CC (gccX or icc, for example). And it is much better for lazy people to do 'export CC=whatever' once and then fire make any number of times ;))

Answering Sam: yes, with my patch it is easier to inherit the variables from the environment. But it is not clear if it is good or bad ;))

But anyway, this patch is only my suggestion, and it can be thrown away :)

-- 
Eygene