Re: Improved git-gui blame viewer

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jun 4, 2007, 06:07 UTC
Message-ID: <20070604060720.GF4507@spearce.org>
In-Reply-To: <f3rhme$2h9$1@sea.gmane.org>

Matthijs Melchior <mmelchior@xs4all.nl> wrote:

> The colors look much better.

Thank Linus.  He's not a user inteface guy, but his idea was actually
pretty good.  ;-)

Show 5 quoted lines

> The behavior has some rough edges. I don't like the following:
>   When clicking on a link in the left column, the file as present in
>   that commit is loaded, positioned at the top. I would like for the
>   line where I clicked is to stay at the same position on the screen,
>   so I do not have to find it again.

Me too.  Unfortunately I'm fighting with Tk to make this work.
Right now I've got the code written to do this, and I see it happen
internally, but then something causes Tk to reset the viewport back
to the top.  Arrrrrrgh.  I haven't pushed it out because it doesn't
work.

>   Also, when returning I would like most lines on the screen stay the
>   same.

Ditto.

>   When clicking on a light gray line to become a green line, then
>   adjacent areas are not correctly colored.  A few adjacent entries
>   become all same gray... [Look around git-gui.sh:340]

This (I think) is because of the way the color selections are being done. git-gui is being stupid and just alternating colors to commits as they come in from `git blame --incremental`. The thing about the incremental blame is I can receive data for any part of the file at any time. So in general what happens is I get data for one part of the file, give it color A, then data for another part, give it color B, and then get data for part that is right next to the first A and assign it A again. So you see chunks where there is no alternating...

>   Something I want for the normal window, in the Staged and Unstaged
>   file lists, high-lite the last entry selected so it becomes easy to
>   click on the next one and I can see more clearly what is displayed
>   in the bottom area.

I'm not sure I understand what you are looking for here. Right now git-gui should be inverting the foreground/background colors on the file that is "selected" (shown in the lower diff view pane). So the background should be black, and the foreground white. Is this not happening? Or are you looking for something else?

-- 
Shawn.