git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Improved git-gui blame viewer

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jun 2, 2007, 04:17 UTC
Message-ID
<20070602041723.GD7044@spearce.org>
A long time ago Linus Torvalds <torvalds@linux-foundation.org> wrote:
Show 25 quoted lines
> 
> On Sun, 18 Mar 2007, Shawn O. Pearce wrote:
> > Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > > 
> > > Of course, the git gui blame colorization is clearly done by somebody who 
> > > is still actively popping LSD with both fists and didn't realize that the 
> > > 60's are long done, but that's another issue.
> > 
> > git-gui is open source.  I'd be happy to take a patch.  Or,
> > since that is horribly messy Tcl/Tk code, just a better color
> > suggestion. :-)
> 
> I would suggest:
> 
>  - some special color for "currently selected" (which defaults to being 
>    the first one coming out of the blame thing, of course). 
> 
>    I'd suggest "black text on pale green background", but that may be just 
>    me.
> 
>  - some *stable* graduated color for the rest. I don't think it 
>    necessarily needs to be "older" vs "newer", and in fact I'd suggest 
>    just two slightly different shades of gray for the background - just 
>    pick alternating shades for each blame entry that comes in (and leave 
>    un-blamed lines white).

I finally got the git-gui code to the point where cleaning up the user interface was possible without sending myself to the nut house.

I tried out Linus' suggestions for coloring, and I like them. Enough that they are now sitting in my `pu` branch on repo.or.cz/git-gui.git.

There's also a whole slew of other improvements to the blame viewer, like being able to dig through history by clicking on commit ids, and tooltips when you mouse over a region of the file.

Behavior on Windows is actually quite good; its less so on Mac OS X. I'm fighting Tk there a little bit more than I should be. Untested on Linux, so I'd love to hear some feedback on it.

  git://repo.or.cz/git-gui.git      pu
  http://repo.or.cz/r/git-gui.git   pu
 
-- 
Shawn.
Next: Matthijs Melchior
Message 1 of 12 in “Improved git-gui blame viewer”
  1. Shawn O. PearceJun 2, 2007
  2. Matthijs MelchiorJun 2, 2007
  3. Shawn O. PearceJun 4, 2007
  4. Martin WaitzJun 4, 2007
  5. Shawn O. PearceJun 4, 2007
  6. Martin WaitzJun 4, 2007
  7. Matthijs MelchiorJun 4, 2007
  8. Shawn O. PearceJun 5, 2007
  9. Matthijs MelchiorJun 5, 2007
  10. Alex RiesenJun 4, 2007
  11. Shawn O. PearceJun 5, 2007
  12. Alex RiesenJun 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.