git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGIT PATCH] Test "stg rebase" after "stg commit"

From
Yann Dirson <ydirson@altern.org>
Date
Jun 2, 2007, 19:04 UTC
Message-ID
<20070602190429.GA6992@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To
<20070506142233.GA20017@diana.vm.bytemark.co.uk>
On Sun, May 06, 2007 at 04:22:33PM +0200, Karl Hasselström wrote:
Show 23 quoted lines
> On 2007-05-06 15:39:09 +0200, Yann Dirson wrote:
> 
> > Well, this case clearly falls in the category of "actions outside
> > stgit that make it possible to rebase without a loss". But then it
> > is also clear that the action of tagging makes the committed patch
> > reachable, and thus the rebase loss-less.
> >
> > The safety check could be possibly be rewritten as "check if current
> > base is reachable without using any refs from current series".
> 
> Yes, I like that idea _much_ better. That's what we _should_ be
> testing for, given that the objective is to keep all commits
> reachable.
> 
> So, how can we do that? gitk displays, when you view a commit, the
> heads through which that commit is reachable. How does it compute
> that? Hmm, it seems like this type of construct works for selecting
> only those commits that are only reachable through a given ref:
> 
>   gitk origin/pu --not $(git show-ref | grep -v refs/remotes/origin/pu| cut -f 1 -d ' ')
> 
> Of course, one could use git log instead of gitk if it turns out to be
> too hard to write an x-windows parser for stgit. :-)

Indeed, gitk calls git-rev-list with those arguments, so the check can be easily rewritten :)

Best regards,
-- 
Yann
Previous: Karl Hasselström
Message 6 of 6 in “Test "stg rebase" after "stg commit"”
  1. Test "stg rebase" after "stg commit"Karl Hasselström, May 4, 2007
  2. Karl HasselströmMay 6, 2007
  3. Yann DirsonMay 6, 2007
  4. Yann DirsonMay 6, 2007
  5. Karl HasselströmMay 6, 2007
  6. Yann DirsonJun 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.