git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGIT PATCH] Test "stg rebase" after "stg commit"

From
Karl Hasselström <kha@treskal.com>
Date
May 4, 2007, 08:13 UTC
Message-ID
<20070504081021.14786.77675.stgit@yoghurt>
Two new tests for "stg rebase":
  1. Try to rebase to a commit that is ahead of HEAD. This should
     work, and does.
  2. Try to commit a patch, and then rebase. This doesn't work,
     because "stg rebase" aborts if orig-base != base, and "stg
     commit" doesn't update orig-base. (It does work if "stg rebase"
     is given the --force flag.)
Signed-off-by: Karl Hasselström <kha@treskal.com>
---

(2) shows a bug in "stg rebase"'s safety logic. I'm not sure how to fix it, because I don't know how it's supposed to work in the first place. (An obvious fix would be to update it whenever the base changes, but that'll take some work, and I'm not convinced it can't be done with les work. Yes, I'm lazy.) Yann, could you explain?

 t/t2200-rebase.sh |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/t/t2200-rebase.sh b/t/t2200-rebase.sh
index 52462dd..b48e513 100755
--- a/t/t2200-rebase.sh
+++ b/t/t2200-rebase.sh
@@ -30,4 +30,20 @@ test_expect_success \
 	test `stg id base@stack` = `git rev-parse master~1`
 	'
 
+test_expect_success \
+	'Rebase to next commit' \
+	'
+	stg rebase master &&
+	test $(stg id base@stack) = $(git rev-parse master)
+	'
+
+test_expect_success \
+	'Commit the patch and rebase again' \
+	'
+	stg commit &&
+	git tag committed-here &&
+	stg rebase master &&
+	test $(stg id base@stack) = $(git rev-parse master)
+	'
+
 test_done
Next: Karl Hasselström
Message 1 of 6 in “Test "stg rebase" after "stg commit"”
  1. Test "stg rebase" after "stg commit"Karl Hasselström, May 4, 2007
  2. Karl HasselströmMay 6, 2007
  3. Yann DirsonMay 6, 2007
  4. Yann DirsonMay 6, 2007
  5. Karl HasselströmMay 6, 2007
  6. Yann DirsonJun 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.