Re: [PATCH 2/2] git-svn: fix segfaults due to initial SVN pool being cleared
On Sun, May 13, 2007 at 01:04:44AM -0700, Eric Wong wrote:
Show 29 quoted lines
> Some parts of SVN always seem to use it, even if the SVN::Ra
> object we're using is no longer used and we've created a new one
> in its place. It's also true that only one SVN::Ra connection
> can exist at once... Using SVN::Pool->new_default when the
> SVN::Ra object is created doesn't seem to help very much,
> either...
>
> Hopefully this fixes all segfault problems users have been
> experiencing over the past few months.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
> git-svn.perl | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index ee69598..5352470 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2904,7 +2904,6 @@ sub new {
> my ($class, $url) = @_;
> $url =~ s!/+$!!;
> return $RA if ($RA && $RA->{url} eq $url);
> - $RA->{pool}->clear if $RA;
>
> SVN::_Core::svn_config_ensure($config_dir, undef);
> my ($baton, $callbacks) = SVN::Core::auth_open_helper([
> --
> 1.5.2.rc3.18.gf0c86 I confirm it fixes every segfault I was able to reproduce with any
prior version :)
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org