git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-svn: fix segfaults due to initial SVN pool being cleared

From
EWEric Wong <normalperson@yhbt.net>
Date
May 13, 2007, 08:04 UTC
Message-ID
<11790434862131-git-send-email-normalperson@yhbt.net>
In-Reply-To
<11790434841909-git-send-email-normalperson@yhbt.net>

Some parts of SVN always seem to use it, even if the SVN::Ra object we're using is no longer used and we've created a new one in its place. It's also true that only one SVN::Ra connection can exist at once... Using SVN::Pool->new_default when the SVN::Ra object is created doesn't seem to help very much, either...

Hopefully this fixes all segfault problems users have been experiencing over the past few months.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-svn.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index ee69598..5352470 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2904,7 +2904,6 @@ sub new {
 	my ($class, $url) = @_;
 	$url =~ s!/+$!!;
 	return $RA if ($RA && $RA->{url} eq $url);
-	$RA->{pool}->clear if $RA;
 
 	SVN::_Core::svn_config_ensure($config_dir, undef);
 	my ($baton, $callbacks) = SVN::Core::auth_open_helper([
-- 
1.5.2.rc3.18.gf0c86
Previous: Eric WongNext: Pierre Habouzit
Message 2 of 4 in “git-svn: clean up caching of SVN::Ra functions”
  1. 1/2 git-svn: clean up caching of SVN::Ra functionsEric Wong, May 13, 2007
  2. 2/2 git-svn: fix segfaults due to initial SVN pool being clearedEric Wong, May 13, 2007
  3. Pierre HabouzitMay 13, 2007
  4. Junio C HamanoMay 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.