git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Git.pm: config_boolean() -> config_bool()

From
Petr Baudis <pasky@suse.cz>
Date
May 9, 2007, 15:13 UTC
Message-ID
<20070509151337.GX4489@pasky.or.cz>
In-Reply-To
<20070509104941.GK4489@pasky.or.cz>
On Wed, May 09, 2007 at 12:49:41PM CEST, Petr Baudis wrote:
Show 15 quoted lines
> @@ -526,14 +528,16 @@ This currently wraps command('config') so it is not so fast.
>  
>  =cut
>  
> -sub config_boolean {
> +sub config_bool {
>  	my ($self, $var) = @_;
>  	$self->repo_path()
>  		or throw Error::Simple("not a repository");
>  
>  	try {
> -		return $self->command_oneline('config', '--bool', '--get',
> -					      $var);
> +		my $val = $self->command_oneline('config', '--bool', '--get',
> +					      $val);
                                               ^^^

Sorry, should be $var. Looks like I forgot to make install or something when "testing" the patch, also judging by the error messages repo.or.cz spewed furiously in the last update round.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett
Previous: Petr BaudisNext: Junio C Hamano
Message 11 of 13 in “Git.pm: config_boolean() -> config_bool()”
  1. 1/4 Git.pm: config_boolean() -> config_bool()Petr Baudis, Apr 27, 2007
  2. 2/4 Git.pm: Add remote_refs() git-ls-remote frontendPetr Baudis, Apr 27, 2007
  3. 3/4 [PATCH] git-mirror - exactly mirror another repositoryPetr Baudis, Apr 27, 2007
  4. Shawn O. PearceApr 27, 2007
  5. 4/4 server info: Add HEAD to info/refsPetr Baudis, Apr 27, 2007
  6. Junio C HamanoApr 27, 2007
  7. Petr BaudisApr 27, 2007
  8. Junio C HamanoApr 27, 2007
  9. Junio C HamanoApr 28, 2007
  10. Git.pm: config_boolean() -> config_bool()Petr Baudis, May 9, 2007
  11. Petr BaudisMay 9, 2007
  12. Junio C HamanoMay 10, 2007
  13. Junio C HamanoMay 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.