From: Petr Baudis Date: Wed, 09 May 2007 15:13:37 GMT Subject: Re: [PATCH] Git.pm: config_boolean() -> config_bool() Message-ID: <20070509151337.GX4489@pasky.or.cz> In-Reply-To: <20070509104941.GK4489@pasky.or.cz> On Wed, May 09, 2007 at 12:49:41PM CEST, Petr Baudis wrote: > @@ -526,14 +528,16 @@ This currently wraps command('config') so it is not so fast. > > =cut > > -sub config_boolean { > +sub config_bool { > my ($self, $var) = @_; > $self->repo_path() > or throw Error::Simple("not a repository"); > > try { > - return $self->command_oneline('config', '--bool', '--get', > - $var); > + my $val = $self->command_oneline('config', '--bool', '--get', > + $val); ^^^ Sorry, should be $var. Looks like I forgot to make install or something when "testing" the patch, also judging by the error messages repo.or.cz spewed furiously in the last update round. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Ever try. Ever fail. No matter. // Try again. Fail again. Fail better. -- Samuel Beckett