git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git gui and my ö

From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date
Apr 24, 2007, 08:57 UTC
Message-ID
<20070424085715.GA9334@informatik.uni-freiburg.de>
In-Reply-To
<20070424061652.GP17480@spearce.org>
Hello Shawn,
Shawn O. Pearce wrote:
Show 22 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> wrote:
> > Uwe Kleine-K??nig <ukleinek@informatik.uni-freiburg.de> wrote:
> > > 	commit-tree failed:
> > > 	Warning: commit message does not conform to UTF-8.
> 
> This was starting to bug me, so I went off and found it.  OK, well
> the encoding error anyway.  git-gui incorrectly claimed commit-tree
> failed when it didn't.  But besides the point, this is the bad line:
> 
> >    1294     fconfigure $msg_wt -encoding $enc -translation binary
> 
> I have had trouble in the past with trying to use that magic
> -encoding flag on fconfigure to get Tcl's file channels to perform
> encoding work for me.  Seems it doesn't work right or something...
> so other parts of git-gui (e.g. the filename handling parts)
> perform the convertfrom/convertto logic on their own... but the
> commit message handling parts didn't.
> 
> They do now (git gui 0.6.5-11-gf20db5f).
> 
> Can you please test my current master branch and see if that fixes
> things for you?  repo.or.cz, git-gui.git...

Works fine. I pulled in your changes[1] and it worked with one test case. (I amended the merge and added a sign-off. ;-)

Best regards and thanks Uwe

[1] Thanks to gitster in #git to explain how to do it.  It's as easy as:
	git pull -s subtree git://.../git-gui.git master
-- 
Uwe Kleine-König

http://www.google.com/search?q=gravity+on+earth%3D
Previous: Shawn O. Pearce
Message 4 of 4 in “[BUG] git gui and my ö”
  1. Uwe Kleine-KönigApr 23, 2007
  2. Shawn O. PearceApr 24, 2007
  3. Shawn O. PearceApr 24, 2007
  4. Uwe Kleine-KönigApr 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.