Re: [BUG] git gui and my ö

From: Shawn O. Pearce <spearce@spearce.org>
Date: Apr 24, 2007, 06:16 UTC
Message-ID: <20070424061652.GP17480@spearce.org>
In-Reply-To: <20070424053935.GO17480@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> wrote:

> Uwe Kleine-K??nig <ukleinek@informatik.uni-freiburg.de> wrote:
> > 	commit-tree failed:
> > 	Warning: commit message does not conform to UTF-8.

This was starting to bug me, so I went off and found it. OK, well the encoding error anyway. git-gui incorrectly claimed commit-tree failed when it didn't. But besides the point, this is the bad line:

>    1294     fconfigure $msg_wt -encoding $enc -translation binary

I have had trouble in the past with trying to use that magic -encoding flag on fconfigure to get Tcl's file channels to perform encoding work for me. Seems it doesn't work right or something... so other parts of git-gui (e.g. the filename handling parts) perform the convertfrom/convertto logic on their own... but the commit message handling parts didn't.

They do now (git gui 0.6.5-11-gf20db5f).

Can you please test my current master branch and see if that fixes things for you? repo.or.cz, git-gui.git...

If it does, I'm probably going to tag that as 0.6.6 and let Junio cut 1.5.2 with that release.

-- 
Shawn.