Re: git-index-pack really does suck..

From: Shawn O. Pearce <spearce@spearce.org>
Date: Apr 3, 2007, 21:17 UTC
Message-ID: <20070403211709.GJ27706@spearce.org>
In-Reply-To: <Pine.LNX.4.64.0704031411320.6730@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

Show 9 quoted lines

> On Tue, 3 Apr 2007, Shawn O. Pearce wrote:
> > If its the missing-object lookup that is expensive, maybe we should
> > try to optimize that.  We do it enough already in other parts of
> > the code...
> 
> Well, for all other cases it's really the "object found" case that is 
> worth optimizing for, so I think optimizing for "no object" is actually 
> wrong, unless it also speeds up (or at least doesn't make it worse) the 
> "real" normal case.

Right. But maybe we shouldn't be scanning for packfiles every time we don't find a loose object. Especially if the caller is in a context where we actually *expect* to not find said object like half of the time... say in git-add/update-index. ;-)

-- 
Shawn.