Re: git-index-pack really does suck..

From: Shawn O. Pearce <spearce@spearce.org>
Date: Apr 3, 2007, 21:11 UTC
Message-ID: <20070403211149.GI27706@spearce.org>
In-Reply-To: <alpine.LFD.0.98.0704031657130.28181@xanadu.home>

Nicolas Pitre <nico@cam.org> wrote:

Show 13 quoted lines

> On Tue, 3 Apr 2007, Linus Torvalds wrote:
> 
> > All that extra memory is just for SHA1 commit ID information. 
> 
> I don't see where that might be.  The only thing that the paranoia check 
> triggers is:
> 
> 	foo = read_sha1_file(blah);
> 	memcmp(foo with bar);
> 	free(foo);
> 
> So where is that commit ID information actually stored when using 
> read_sha1_file()?

That might just be the mmap code in sha1_file.c. We are mmaping the existing packfile, to fetch the object. That counts as virtual memory. ;-)

-- 
Shawn.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.