Re: [PATCH] Added options NO_TCLTK, WITH_P4IMPORT and --with-tcltk/--without-tcltk.

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: Mar 26, 2007, 10:03 UTC
Message-ID: <20070326100344.GV14837@codelabs.ru>
In-Reply-To: <7vmz20xuxq.fsf@assigned-by-dhcp.cox.net>

Jakub, Junio,

Mon, Mar 26, 2007 at 01:36:49AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > Thanks a lot for the patch, but...
> >
> > Eygene Ryabinkin wrote:
> >
> >> Internal make option TCLTK was added: it governs the location of
> >> the Tcl/Tk interpreter, so user can specify its own binary location
> >> either with './configure --with-tcltk=/path/to/binary' or
> >> 'TCLTK=/path/to/binary make'.
> >
> > ...shouldn't it be TCLTK_PATH?

Yes, probably is should be TCLTK_PATH.

> Thanks for sanity checking.  That means that the absense of
> tcltk would make it impossible to munge the scripts to point at
> the wish binary, so makes the NO_TCLTK stuff easier to swallow.

Sorry, did not get the point. The TCLTK is initialized to the 'wish' by 'TCLTK ?= wish', so TCLTK will always be here and initialized to the wish by-default.

-- 
Eygene