Re: [PATCH] Added make options NO_GUI and WITH_P4IMPORT.
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Mar 24, 2007, 23:16 UTC
- Message-ID
- <200703250016.25963.jnareb@gmail.com>
- In-Reply-To
- <81b0412b0703210758v32e7a692p426f45de9ee6db42@mail.gmail.com>
On Wed, Mar 21, 2007, Alex Riesen wrote:
> On 3/21/07, Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
Show 6 quoted lines
>> Yep, you're right. That was I meant originally. How do you feel >> about NO_GUI or NO_TCL names? > > That'd be NO_TCL_TK. TCL has nothing to do with graphics. > And you have one more supporter for NO_GUI (my server has no > usable graphics, will never have and runs cron jobs with git in them).
Actually the value for NO_TCL_TK (or NO_TCLTK) can be detected automatically by ./configure in similar way that we used to detect the existence of Python in the old days when there were core code which written in Python. Perhaps we should provide way to override autodetection _and_ provide path to 'wish' executable with the --with-wish=PATH or --with-tcltk=PATH to ./configure script (similar to how Python dependency was handled, and how paths to shell and Perl are handled).
The NO_GUI is another issue, if to be configured by ./configure script, then only as an user option, not something to be autodetected: either --without-gui (treat gui as package, although usually it is about package to be used, not package provided) or --disable-gui (treat gui as feature of project).
The fact that all GUI that comes with git repository is in Tcl/Tk slightly clouds this issue. As do the fact that those affect only installation stage, and not build (well, with the exception of WISH_PATH / TCLTK_PATH).
-- Jakub Narebski Poland