Re: Errors cloning large repo

From: Martin Waitz <tali@admingilde.org>
Date: Mar 11, 2007, 21:35 UTC
Message-ID: <20070311213523.GB20726@admingilde.org>
In-Reply-To: <Pine.LNX.4.64.0703101443411.10330@woody.linux-foundation.org>

hoi :)

On Sat, Mar 10, 2007 at 02:46:35PM -0800, Linus Torvalds wrote:

> Are you sure you're not just running a 64-bit process?

pretty sure, yes :-)

> 64-bit processes don't need O_LARGEFILE to process files larger than 2GB, 
> since for them, off_t is already 64-bit.

but O_LARGEFILE is a Linux-only thing, right?

Show 7 quoted lines

> Oh, except we have that 
> 
> 	#define _FILE_OFFSET_BITS 64
> 
> which is just a horrible hack. That's nasty. We should just use 
> O_LARGEFILE rather than depend on some internal glibc thing that works 
> nowhere else.

Well, if I remember correctly the *BSD systems always use 64bit now, its sad that glibc does not do the same out of the box for Linux. _FILE_OFFSET_BITS is the documented way to get 64bit file sizes on glibc, so I think it is the right thing for us (even when that define is really ugly).

-- 
Martin Waitz