Re: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Date: Mar 6, 2007, 07:47 UTC
Message-ID: <20070306074740.GB26626@filer.fsl.cs.sunysb.edu>
In-Reply-To: <1173164506.4877.19.camel@gandalf.dcc.usm.my>

On Tue, Mar 06, 2007 at 03:01:46PM +0800, Nur Hussein wrote:

Show 20 quoted lines

> A bug occurred where the temporary mbox is deleted even when 'N' or 'n' was selected
> because of the incorrect use of the -a operator when testing user input. Fixed now to
> use -o instead.
> 
> Signed-off-by: Nur Hussein <hussein@cs.usm.my>
> ---
>  guilt-patchbomb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/guilt-patchbomb b/guilt-patchbomb
> index 6f51b4b..ad80fb1 100755
> --- a/guilt-patchbomb
> +++ b/guilt-patchbomb
> @@ -88,5 +88,5 @@ fi
>  echo -n "Delete temporary directory? [Y/n] "
>  read n
>  
> -[ "$n" != "n" -a "$n" != "N" ] && exit 0
> +[ "$n" != "n" -o "$n" != "N" ] && exit 0
>  rm -rf $dir

Would this actually work?

input $n != n $n != N action (-a) action (-o) --------------------------------------------------------------------------- <not N> true true exit exit n false true rm exit N true false rm exit

The new statement seems wrong. The fact that the original statement had the logic inverted still remains. It should be exit if ($n==n || $n==N).

Josef "Jeff" Sipek.

-- 
Research, n.:
  Consider Columbus:
    He didn't know where he was going.
    When he got there he didn't know where he was.
    When he got back he didn't know where he had been.
    And he did it all on someone else's money.