threads / patch / 7106

patchGuilt: Fixed guilt-patchbomb temporary mbox deletion bug

Subject: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

## tl;dr

5 messages between Mar 6, 2007 and Mar 6, 2007. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Nur Hussein· Mar 6, 2007, 07:01 UTC · lore

A bug occurred where the temporary mbox is deleted even when 'N' or 'n' was selected because of the incorrect use of the -a operator when testing user input. Fixed now to use -o instead.

Signed-off-by: Nur Hussein <hussein@cs.usm.my>
---
 guilt-patchbomb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to guilt-patchbomb +1 −1
diff --git a/guilt-patchbomb b/guilt-patchbomb
index 6f51b4b..ad80fb1 100755
--- a/guilt-patchbomb
+++ b/guilt-patchbomb
@@ -88,5 +88,5 @@ fi
 echo -n "Delete temporary directory? [Y/n] "
 read n
 
-[ "$n" != "n" -a "$n" != "N" ] && exit 0
+[ "$n" != "n" -o "$n" != "N" ] && exit 0
 rm -rf $dir

-- 
1.4.4.4


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Junio C Hamano· Mar 6, 2007, 07:06 UTC · re: Nur Hussein · lore

Re: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

Nur Hussein <hussein@cs.usm.my> writes:
Show 6 quoted lines
>  echo -n "Delete temporary directory? [Y/n] "
>  read n
>  
> -[ "$n" != "n" -a "$n" != "N" ] && exit 0
> +[ "$n" != "n" -o "$n" != "N" ] && exit 0
>  rm -rf $dir
Is it just me who finds this much more readable?
	case "$n" in [nN]*) exit 0 ;; esac
Josef Sipek· Mar 6, 2007, 07:38 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

On Mon, Mar 05, 2007 at 11:06:26PM -0800, Junio C Hamano wrote:
Show 12 quoted lines
> Nur Hussein <hussein@cs.usm.my> writes:
> 
> >  echo -n "Delete temporary directory? [Y/n] "
> >  read n
> >  
> > -[ "$n" != "n" -a "$n" != "N" ] && exit 0
> > +[ "$n" != "n" -o "$n" != "N" ] && exit 0
> >  rm -rf $dir
> 
> Is it just me who finds this much more readable?
> 
> 	case "$n" in [nN]*) exit 0 ;; esac
 
I don't know. I never saw case being "abused" as the condition in a while
loop either. I guess it is really a matter of taste. For anything more
complex then [nN] I'd go with the case statement as well.

I hear that the whole while-case is just an optimization for sh of many moons ago - something about case being builtin but test not.

Josef "Jeff" Sipek.
-- 
Only two things are infinite, the universe and human stupidity, and I'm not
sure about the former.
		- Albert Einstein
Josef Sipek· Mar 6, 2007, 07:47 UTC · re: Nur Hussein · lore

Re: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

On Tue, Mar 06, 2007 at 03:01:46PM +0800, Nur Hussein wrote:
Show 20 quoted lines
> A bug occurred where the temporary mbox is deleted even when 'N' or 'n' was selected
> because of the incorrect use of the -a operator when testing user input. Fixed now to
> use -o instead.
> 
> Signed-off-by: Nur Hussein <hussein@cs.usm.my>
> ---
>  guilt-patchbomb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/guilt-patchbomb b/guilt-patchbomb
> index 6f51b4b..ad80fb1 100755
> --- a/guilt-patchbomb
> +++ b/guilt-patchbomb
> @@ -88,5 +88,5 @@ fi
>  echo -n "Delete temporary directory? [Y/n] "
>  read n
>  
> -[ "$n" != "n" -a "$n" != "N" ] && exit 0
> +[ "$n" != "n" -o "$n" != "N" ] && exit 0
>  rm -rf $dir
Would this actually work?

input $n != n $n != N action (-a) action (-o) --------------------------------------------------------------------------- <not N> true true exit exit n false true rm exit N true false rm exit

The new statement seems wrong. The fact that the original statement had the logic inverted still remains. It should be exit if ($n==n || $n==N).

Josef "Jeff" Sipek.
-- 
Research, n.:
  Consider Columbus:
    He didn't know where he was going.
    When he got there he didn't know where he was.
    When he got back he didn't know where he had been.
    And he did it all on someone else's money.
Josef Sipek· Mar 6, 2007, 07:53 UTC · re: Josef Sipek · lore

Re: [PATCH 1/1] Guilt: Fixed guilt-patchbomb temporary mbox deletion bug

On Tue, Mar 06, 2007 at 02:47:41AM -0500, Josef Sipek wrote:
Show 33 quoted lines
> On Tue, Mar 06, 2007 at 03:01:46PM +0800, Nur Hussein wrote:
> > A bug occurred where the temporary mbox is deleted even when 'N' or 'n' was selected
> > because of the incorrect use of the -a operator when testing user input. Fixed now to
> > use -o instead.
> > 
> > Signed-off-by: Nur Hussein <hussein@cs.usm.my>
> > ---
> >  guilt-patchbomb |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/guilt-patchbomb b/guilt-patchbomb
> > index 6f51b4b..ad80fb1 100755
> > --- a/guilt-patchbomb
> > +++ b/guilt-patchbomb
> > @@ -88,5 +88,5 @@ fi
> >  echo -n "Delete temporary directory? [Y/n] "
> >  read n
> >  
> > -[ "$n" != "n" -a "$n" != "N" ] && exit 0
> > +[ "$n" != "n" -o "$n" != "N" ] && exit 0
> >  rm -rf $dir
> 
> Would this actually work?
> 
> input		$n != n		$n != N		action (-a)	action (-o)
> ---------------------------------------------------------------------------
> <not N>		true		true		exit		exit
> n		false		true		rm		exit
> N		true		false		rm		exit
> 
> 
> The new statement seems wrong. The fact that the original statement had the
> logic inverted still remains. It should be exit if ($n==n || $n==N).
I fixed it up and commited it.
Thanks,
Josef "Jeff" Sipek.
-- 
It used to be said [...] that AIX looks like one space alien discovered
Unix, and described it to another different space alien who then implemented
AIX. But their universal translators were broken and they'd had to gesture a
lot.
		- Paul Tomblin

← back to recent threads