Re: [EGIT PATCH 6/9] Add branch and StGit patch to decorator
torsdag 01 mars 2007 04:59 skrev Shawn O. Pearce:
Show 9 quoted lines
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > + public String getPatch() throws IOException {
> > + final File ptr = new File(getDirectory(),"patches/"+getBranch()+"/current");
> > + final BufferedReader br = new BufferedReader(new FileReader(ptr));
> > + final String line = br.readLine();
> > + return line;
> > + }
>
> Last time I checked leaking a file descriptor was a bad idea.It's a hallmark of mine. Sooner or later the GC picks them up :), but you're right.
> I fixed it (in both methods) when I applied the patch.
>
> Your whole series is now pushed. Thanks for the cleanups.
>
Robin Rosenberg <robin.rosenberg@dewire.com>