From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Thu, 01 Mar 2007 08:22:17 GMT
Subject: Re: [EGIT PATCH 6/9] Add branch and StGit patch to decorator
Message-ID: <200703010922.18149.robin.rosenberg@dewire.com>
In-Reply-To: <20070301035909.GA8103@spearce.org>

torsdag 01 mars 2007 04:59 skrev Shawn O. Pearce:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > +	public String getPatch() throws IOException {
> > +		final File ptr = new File(getDirectory(),"patches/"+getBranch()+"/current");
> > +		final BufferedReader br = new BufferedReader(new FileReader(ptr));
> > +		final String line = br.readLine();
> > +		return line;
> > +	}
> 
> Last time I checked leaking a file descriptor was a bad idea.
It's a hallmark of mine. Sooner or later the GC picks them up :), but you're right.

> I fixed it (in both methods) when I applied the patch.
> 
> Your whole series is now pushed. Thanks for the cleanups.
> 

-- robin