Re: git-gui Error

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 15, 2007, 06:38 UTC
Message-ID: <20070215063855.GA30643@spearce.org>
In-Reply-To: <20070215060712.GA3761@auto.tuwien.ac.at>

Martin Koegler <mkoegler@auto.tuwien.ac.at> wrote:

> This time, the white spaces/tabs should be correct:

Thanks, that applied cleanly.

Except the radio button for Tag isn't selected if you make a selection from the tag picklist. This was easily fixed by adding a trace to the variable, like the trace already setup for the branch and tracking branch menus:

diff --git a/git-gui.sh b/git-gui.sh
index 1c3de80..9ce5a3b 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2018,6 +2018,8 @@ trace add variable create_branch_head write \
 	[list radio_selector create_branch_revtype head]
 trace add variable create_branch_trackinghead write \
 	[list radio_selector create_branch_revtype tracking]
+trace add variable create_branch_tag write \
+	[list radio_selector create_branch_revtype tag]
 
 trace add variable delete_branch_head write \
 	[list radio_selector delete_branch_checktype head]

I applied your patch along with the new trace above, and have pushed
it out as the following:

commit 101e3ae7a6b041aa86505bfd3e8b901f1dc245c3
Author: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Date:   Thu Feb 15 01:28:34 2007 -0500

    git-gui: Create new branches from a tag.
    
    I'm missing the possibility to base a new branch on a tag.
    The following adds a tag drop down to the new branch dialog.
    
    Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
    Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.