Re: git-gui Error

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 15, 2007, 02:40 UTC
Message-ID: <20070215024014.GA29865@spearce.org>
In-Reply-To: <20070214174635.GA21612@auto.tuwien.ac.at>

Martin Koegler <mkoegler@auto.tuwien.ac.at> wrote:

> I'm missing the possibility to base a new branch on a tag.
> The following adds a tag drop down to the new branch dialog:

Yea, again, laziness on my part.  :-) You could enter the tag name
in the SHA-1 expression field, but having it as a picklist may
make sense.

Show 5 quoted lines

> --- git-gui.sh  2007-02-14 08:51:38.025781229 +0000
> +++ git-gui     2007-02-14 10:50:13.618870598 +0000
> @@ -1916,11 +1916,25 @@
>         return [lsort -unique $all_trackings]
>  }

Unfortunately this patch has severe whitespace damage. All of the tabs were received here as spaces, so nothing applies.

Show 6 quoted lines

>  proc do_create_branch_action {w} {
>         global all_heads null_sha1 repo_config
>         global create_branch_checkout create_branch_revtype
>         global create_branch_head create_branch_trackinghead
>         global create_branch_name create_branch_revexp
> +        global create_branch_tag

The indentation does not line up here. All of the existing context lines were indented with just one tab, until the whitespace damage noted above.

-- 
Shawn.