Re: [PATCH] Documentation: add KMail in SubmittingPatches

From: Andy Parkins <andyparkins@gmail.com>
Date: Feb 6, 2007, 14:47 UTC
Message-ID: <200702061447.51459.andyparkins@gmail.com>
In-Reply-To: <7vveigkmpv.fsf@assigned-by-dhcp.cox.net>

On Tuesday 2007 February 06 03:07, Junio C Hamano wrote:

> I do not use KMail myself, so I cannot comment on the procedure,
> but from the cursory look it *should* do the right thing.  Only
> that it makes me a bit nervous to see your hunk header being
> line wrapped.

I use Kmail for submitting patches, and it seems to work okay. The important thing is to turn word wrap off as soon as you open it. If you did this:

 * Save patch as draft (say with git-imap-send)
 * Open draft
 * Close draft
 * Open draft
 * Turn word wrap off
 * Send

You would have a badly wrapped patch. The reason is that until you store the email again, kmail seems to know the difference between a hard LF that was in the original email and a LF that it inserted to wrap the lines. So, as soon as you turn word wrap off all the soft LFs go away - perfect. However, if you save without turning word wrap off, all those soft LFs become hard and the next time you open the email there is no easy way to get the untouched email back.

Michael's original instructions seem fine though. I don't think his word wrap problem in this case is the work of KMail.

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com