Re: MinGW port usable

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 30, 2007, 15:27 UTC
Message-ID: <20070130152721.GB25779@spearce.org>
In-Reply-To: <Pine.LNX.4.63.0701301114590.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 8 quoted lines

> On Tue, 30 Jan 2007, Christian MICHON wrote:
> > just to be more clear: when using the .bat shortcut, calling gitk
> > > from within git-gui fails.
> 
> I guess you need to change the .bat shortcut, so that the tcl script is 
> called via bash instead of directly from cmd.
> 
> Otherwise git-gui does not have a chance to find the MSYS environment.

Hmmph. The [is_Cygwin] test within git-gui causes it to setup the .bat shortcut using:

  $(cygpath --windows /bin/sh) --login -c 'git git-gui'

for exactly that reason. I didn't think that with MSYS there was environment to hand down through a shell's init scripts. I thought it was all coming from Windows itself. Oops.

When starting gitk, git-gui assumes (rightly or wrongly) that gitk is a Tcl/Tk script and launches it with the same Tcl interpreter that is running git-gui. I did that to bypass the unnecessary fork/exec of a shell just to enter a wish process. I had assumed that would also work well on the MSYS case. Apparently not.

Patches to git-gui would be welcome. It will probably be a few weeks before I can get an MSYS+Git configuration working that I can test git-gui against. I'm just swamped with too many tasks right now, and this, although interesting enough to fix, is likely to take a back seat.

-- 
Shawn.