git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix shortlog only showing HEAD revision.

From
RFRobert Fitzsimons <robfitz@273k.net>
Date
Jan 3, 2007, 20:25 UTC
Message-ID
<20070103202555.GA25768@localhost>
In-Reply-To
<459C0232.3090804@linuxtv.org>

My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug found by Michael Krufky which caused the passed in hash value to be ignored, so shortlog would only show the HEAD revision.

Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---

Thanks for finding this Michael. It' just a small bug introducted by a recent change I made. Including John 'Warthog9' so hopefully he can add this to the version of gitweb which is hosted on kernel.org.

Robert
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index d845e91..2e94c2c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4423,7 +4423,7 @@ sub git_shortlog {
 	}
 	my $refs = git_get_references();
 
-	my @commitlist = parse_commits($head, 101, (100 * $page));
+	my @commitlist = parse_commits($hash, 101, (100 * $page));
 
 	my $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));
 	my $next_link = '';
-- 
t1.gaaaa
Previous: Michael KrufkyNext: Jakub Narebski
Message 2 of 6 in “GITWEB branch shortlog broken after recent update on kernel.org”
  1. Michael KrufkyJan 3, 2007
  2. gitweb: Fix shortlog only showing HEAD revision.Robert Fitzsimons, Jan 3, 2007
  3. Jakub NarebskiJan 3, 2007
  4. Michael KrufkyJan 5, 2007
  5. J.H.Jan 5, 2007
  6. gitweb: Make shortlog use 'h' (head) parameter againJakub Narebski, Jan 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.