git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Make shortlog use 'h' (head) parameter again

From
Jakub Narebski <jnareb@gmail.com>
Date
Jan 3, 2007, 20:30 UTC
Message-ID
<11678562042320-git-send-email-jnareb@gmail.com>
In-Reply-To
<459C0232.3090804@linuxtv.org>
This fixes typo in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Michael Krufky wrote:
> Ever since gitweb on kernel.org was recently updated, I've been experiencing a
> nasty bug -- It seems that it is no longer possible to view a shortlog from any
> branch or head other than master.
[...]
> "log" and "tree" is working properly -- it seems that "shortlog" is the only
> feature affected by this bug.

This corrects this bug. When introducing parse_commits to shortlog, there was typo in parse_commits arguments: it was $head instead of $hash.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2ead917..2179054 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4423,7 +4423,7 @@ sub git_shortlog {
 	}
 	my $refs = git_get_references();
 
-	my @commitlist = parse_commits($head, 101, (100 * $page));
+	my @commitlist = parse_commits($hash, 101, (100 * $page));
 
 	my $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));
 	my $next_link = '';
-- 
1.4.4.3
Previous: J.H.
Message 6 of 6 in “GITWEB branch shortlog broken after recent update on kernel.org”
  1. Michael KrufkyJan 3, 2007
  2. gitweb: Fix shortlog only showing HEAD revision.Robert Fitzsimons, Jan 3, 2007
  3. Jakub NarebskiJan 3, 2007
  4. Michael KrufkyJan 5, 2007
  5. J.H.Jan 5, 2007
  6. gitweb: Make shortlog use 'h' (head) parameter againJakub Narebski, Jan 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.