git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Dec 31, 2006, 06:12 UTC
Message-ID
<20061231061232.GC6106@spearce.org>
In-Reply-To
<7vy7ooip6y.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 12 quoted lines
> > diff --git a/config.c b/config.c
> > index 2e0d5a8..83ce9e1 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -236,8 +236,16 @@ int git_config_int(const char *name, const char *value)
> >  	if (value && *value) {
> >  		char *end;
> >  		int val = strtol(value, &end, 0);
> > +		while (isspace(*end))
> > +			end++;
> 
> Why?  Are you allowing "1024 k"?  Do we want to?
Yes.  Why not?
-- 
Shawn.
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 8 in “Teach Git how to parse standard power of 2 suffixes.”
  1. 1/2 Teach Git how to parse standard power of 2 suffixes.Shawn O. Pearce, Dec 31, 2006
  2. Junio C HamanoDec 31, 2006
  3. Shawn O. PearceDec 31, 2006
  4. Junio C HamanoDec 31, 2006
  5. Shawn O. PearceDec 31, 2006
  6. Junio C HamanoDec 31, 2006
  7. Shawn O. PearceDec 31, 2006
  8. Shawn O. PearceDec 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.