From: Shawn O. Pearce <spearce@spearce.org>
Date: Sun, 31 Dec 2006 06:12:32 GMT
Subject: Re: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.
Message-ID: <20061231061232.GC6106@spearce.org>
In-Reply-To: <7vy7ooip6y.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> > diff --git a/config.c b/config.c
> > index 2e0d5a8..83ce9e1 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -236,8 +236,16 @@ int git_config_int(const char *name, const char *value)
> >  	if (value && *value) {
> >  		char *end;
> >  		int val = strtol(value, &end, 0);
> > +		while (isspace(*end))
> > +			end++;
> 
> Why?  Are you allowing "1024 k"?  Do we want to?

Yes.  Why not?

-- 
Shawn.