git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook

From
APAndy Parkins <andyparkins@gmail.com>
Date
Dec 21, 2006, 08:39 UTC
Message-ID
<200612210839.35980.andyparkins@gmail.com>
In-Reply-To
<7vslfae4uv.fsf@assigned-by-dhcp.cox.net>
On Wednesday 2006 December 20 19:37, Junio C Hamano wrote:
> I do not think these are insurmountable.

Me either. I wasn't really sure how warmly these patches would be received, so thought some small patches that make the feature highly might be more palatable. I actually don't think that the hook templates is the right place for this work; submodule support is not something you would customise per-repository, and so the hook scripts are manifestly the wrong place for this.

Show 7 quoted lines
> As you fix them and enhance the support, I suspect you would
> want a separate command to manage .gitmodule file and submodules
> referenced by it.  I think it would be better to keep the patch
> to the template to the minimum (for example, run "git submodule
> update" if there is .gitmodules file at the toplevel), and
> implement the body of the processing in "git-submodule.sh", or
> something like that.

That's an interesting idea. I was thinking that git-commit itself would have been the final target; but I certainly don't have any problem with a separate command.

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 11 in “Implement poor-man's submodule support in pre-commit hook”
  1. Implement poor-man's submodule support in pre-commit hookAndy Parkins, Dec 20, 2006
  2. Andy ParkinsDec 20, 2006
  3. Brian GernhardtDec 20, 2006
  4. Jakub NarebskiDec 20, 2006
  5. Andreas EricssonDec 20, 2006
  6. [BUG] git --git-dir dies with bus errorBrian Gernhardt, Dec 20, 2006
  7. Jakub NarebskiDec 20, 2006
  8. Andy ParkinsDec 20, 2006
  9. Junio C HamanoDec 20, 2006
  10. Andy ParkinsDec 21, 2006
  11. Junio C HamanoDec 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.