From: Andy Parkins Date: Thu, 21 Dec 2006 08:39:34 GMT Subject: Re: [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook Message-ID: <200612210839.35980.andyparkins@gmail.com> In-Reply-To: <7vslfae4uv.fsf@assigned-by-dhcp.cox.net> On Wednesday 2006 December 20 19:37, Junio C Hamano wrote: > I do not think these are insurmountable. Me either. I wasn't really sure how warmly these patches would be received, so thought some small patches that make the feature highly might be more palatable. I actually don't think that the hook templates is the right place for this work; submodule support is not something you would customise per-repository, and so the hook scripts are manifestly the wrong place for this. > As you fix them and enhance the support, I suspect you would > want a separate command to manage .gitmodule file and submodules > referenced by it. I think it would be better to keep the patch > to the template to the minimum (for example, run "git submodule > update" if there is .gitmodules file at the toplevel), and > implement the body of the processing in "git-submodule.sh", or > something like that. That's an interesting idea. I was thinking that git-commit itself would have been the final target; but I certainly don't have any problem with a separate command. Andy -- Dr Andy Parkins, M Eng (hons), MIEE andyparkins@gmail.com