git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] editor: make sure $EDITOR is executed as a command

From
Clemens Buchacher <drizzd@aon.at>
Date
Dec 10, 2006, 14:04 UTC
Message-ID
<20061210140457.GA13173@kzelldran.dyndns.org>
In-Reply-To
<20061210135753.GA12905@kzelldran.dyndns.org>
Hi,
Sorry about the missing subject.

Make sure $EDITOR is executed as a command. Otherwise, _editor may fail if $EDITOR is set to something like 'editor', which is also a function within cg-Xlib.

Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d
tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff
parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e
author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100
committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100
 cg-Xlib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cg-Xlib b/cg-Xlib
index c1262bf..9d04eb4 100755
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -568,7 +568,7 @@ _editor()
 	actionname="$1"; shift
 	actionkey="$1"; shift
 
-	${EDITOR:-vi} "$LOGMSG2"
+	command ${EDITOR:-vi} "$LOGMSG2"
 	[ -z "$force" ] || return 0
 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0
Previous: Clemens Buchacher
Message 2 of 2 in “*** SPAM ***”
  1. Clemens BuchacherDec 10, 2006
  2. Clemens BuchacherDec 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.