threads / discuss / 43666

*** SPAM ***

Subject: *** SPAM ***

## tl;dr

2 messages between Dec 10, 2006 and Dec 10, 2006.

replies: 1people: 2as markdown or json

Clemens Buchacher· Dec 10, 2006, 13:57 UTC · lore
Make sure $EDITOR is executed as a command

--- commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100 committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100

 cg-Xlib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cg-Xlib b/cg-Xlib
index c1262bf..9d04eb4 100755
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -568,7 +568,7 @@ _editor()
 	actionname="$1"; shift
 	actionkey="$1"; shift
 
-	${EDITOR:-vi} "$LOGMSG2"
+	command ${EDITOR:-vi} "$LOGMSG2"
 	[ -z "$force" ] || return 0
 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0
Clemens Buchacher· Dec 10, 2006, 14:04 UTC · re: Clemens Buchacher · lore

Re: [PATCH] editor: make sure $EDITOR is executed as a command

Hi,
Sorry about the missing subject.

Make sure $EDITOR is executed as a command. Otherwise, _editor may fail if $EDITOR is set to something like 'editor', which is also a function within cg-Xlib.

Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d
tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff
parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e
author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100
committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100
 cg-Xlib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cg-Xlib b/cg-Xlib
index c1262bf..9d04eb4 100755
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -568,7 +568,7 @@ _editor()
 	actionname="$1"; shift
 	actionkey="$1"; shift
 
-	${EDITOR:-vi} "$LOGMSG2"
+	command ${EDITOR:-vi} "$LOGMSG2"
 	[ -z "$force" ] || return 0
 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0

← back to recent threads