git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Make git-commit cleverer - have it figure out whether it needs -a automatically

From
APAndy Parkins <andyparkins@gmail.com>
Date
Dec 1, 2006, 15:17 UTC
Message-ID
<200612011518.00575.andyparkins@gmail.com>
In-Reply-To
<81b0412b0612010507r5e6ee226t3a1e61113bf15d43@mail.gmail.com>
On Friday 2006 December 01 13:07, Alex Riesen wrote:
> Of course it is. It's just that the problem is not solved yet,
> and if -a becomes git-commit's default a simple git-commit
> will be a real annoying thing.

There was talk of making git-commit -a; bear in mind that this patch was to completely sidestep making that default. This patch has no effect on existing behaviour save for one special case: when commit would otherwise have done nothing, it now does "git-commit -a".

If you have a problem with git-commit -a, then presumably you are already using git-update-index for all your commit needs; in which case this patch has zero impact on you.

> > Wasn't the whole point of this to avoid needing another config option?
>
> was it it the point of breaking existing setups?

Of course it isn't; I have no intention of breaking yours or anybody else's setup. However, as your complaint is that this patch highlights another bug, I would think the solution is fix the other bug, instead of botch around it in this patch.

Perhaps I was a little terse; what I should have said was - I don't really want to solve this executable bit problem with a config option; as that's papering over the cracks. If executable bits are a problem, well why not detect when that's the case automatically. I don't have a cygwin environment so I have no way to test what you ask for.

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
Previous: Alex Riesen
Message 7 of 7 in “Make git-commit cleverer - have it figure out whether it needs -a automatically”
  1. Make git-commit cleverer - have it figure out whether it needs -a automaticallyAndy Parkins, Nov 30, 2006
  2. Jakub NarebskiNov 30, 2006
  3. Johannes SchindelinNov 30, 2006
  4. Alex RiesenNov 30, 2006
  5. Andy ParkinsDec 1, 2006
  6. Alex RiesenDec 1, 2006
  7. Andy ParkinsDec 1, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.