[PATCH/RFC] Make git-commit cleverer - have it figure out whether it needs -a automatically
- From
- Andy Parkins <andyparkins@gmail.com>
- Date
- Nov 30, 2006, 12:59 UTC
- Message-ID
- <200611301259.32387.andyparkins@gmail.com>
Raimund Bauer offered this suggestion (paraphrased):
"Maybe we could do git-commit -a _only_ if the index matches HEAD, and otherwise keep current behavior? So people who don't care about the index won't get tripped up, and when you do have a dirty index, you get told about it?"
Johannes Schindelin pointed out that this isn't the right thing to do for an --amend, so that is checked for.
Additionally, it's probably not the right thing to do if any files are specified with "--only" or "--include", so they turn this behaviour off as well.
Signed-off-by: Andy Parkins <andyparkins@gmail.com> --- I've been using this today, and so far it's been quite friendly. git-commit is suddenly just doing the Right Thing.
It's so good that the only (small) hurdle, is remembering during an amend that you need to update the index first to get any code changes in to the amend - but that is the same as it ever was.
git-commit.sh | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/git-commit.sh b/git-commit.sh index 81c3a0c..e9aed2b 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -265,6 +265,13 @@ $1" done case "$edit_flag" in t) no_edit= ;; esac +# Clever commit - if this commit would do nothing, then make it an "all" +# commit +if [ -z "$(git-diff-index --cached --name-only HEAD)" \ + -a -z "$amend" -a -z "$only" -a -z "$also" ]; then + all=t +fi + ################################################################ # Sanity check options
-- 1.4.4.1.g3ece-dirty