[PATCH] Improve git-prune -n output
- From
- Andy Parkins <andyparkins@gmail.com>
- Date
- Oct 27, 2006, 08:37 UTC
- Message-ID
- <200610270937.11368.andyparkins@gmail.com>
- In-Reply-To
- <7vlkn3kn65.fsf@assigned-by-dhcp.cox.net>
prune_object() in show_only mode would previously just show the path to the object that would be deleted. The path the object is stored in shouldn't be shown to users, they only know about sha1 identifiers so show that instead.
Further, the sha1 alone isn't that useful for examining what is going to be deleted. This patch also adds the object type to the output, which makes it easy to pick out, say, the commits and use git-show to display them.
Signed-off-by: Andy Parkins <andyparkins@gmail.com> --- Fixes issues from...
Junio C Hamano
Do not leave blank inside () pairs.
Do not enclose a single statement in {}.
No longer uses strcpy()Petr Baudis "unknown type" is now simply "unknown"
Andy Parkins No longer outputs "would prune"
builtin-prune.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/builtin-prune.c b/builtin-prune.c index 7290e6d..b8b2d05 100644 --- a/builtin-prune.c +++ b/builtin-prune.c @@ -16,8 +16,14 @@ static struct rev_info revs; static int prune_object(char *path, const char *filename, const unsigned char *sha1) { + char buf[20]; + const char *type; + if (show_only) { - printf("would prune %s/%s\n", path, filename); + type = buf; + if (sha1_object_info(sha1, type, NULL)) + type = "unknown"; + printf("%s %s\n", sha1_to_hex(sha1), type ); return 0; } unlink(mkpath("%s/%s", path, filename));
-- 1.4.3.3.g5bca6